Change when ldconfig runs and what files it looks for #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
approved these changes
Dec 9, 2021
bcressey
reviewed
Dec 9, 2021
Comment on lines
1
to
4
| [Unit] | ||
| # Run `ldconfig.service` after `tmpfilesd`, since `ldconfig` will attempt to | ||
| # read files from `/etc/ld.so.conf.d`, which are created by `tmpfilesd` | ||
| After=systemd-tmpfiles-setup.service |
There was a problem hiding this comment.
Let's put this in glibc as well; I think that's more clear since it's the use of ld.so.conf via tmpfiles that creates this ordering requirement.
arnaldo2792
force-pushed
the
ldconfig
branch
from
507d5ea
to
640f50b
Compare
|
Forced push includes:
|
This commit adds a configuration file for ldconfig to read additional configurations from /etc/ld.so.conf, which will be created at runtime by the tmpfilesd daemon. There are packages that create `ldconfig.d/*.conf` files using a tmpfilesd file to cache additional libraries, thus `ldconfig.service` has to run after the tmpfilesd daemon creates the files. Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
arnaldo2792
force-pushed
the
ldconfig
branch
from
640f50b
to
27e43df
Compare
|
Forced push squashes both commits. In previous versions, the commits modified different packages, and now they modify the same package. |
bcressey
approved these changes
Dec 10, 2021
etungsten
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N / A
Description of changes:
Related to #1799 , that PR is quite big. I'm taking some of the commits in that PR as their individual PR. The commit in this PR is variant independent, since it changes a package used among all variants.
There are packages that create
ldconfig.d/*.conffiles using a tmpfilesd file to cache additional libraries, thusldconfig.servicehas to run after the tmpfilesd daemon creates the files.This commit adds a configuration file for ldconfig to read additional configurations from /etc/ld.so.conf, which will be created at runtime by the tmpfilesd daemon.
Testing done:
ldconfig.servicewaits forsystemd-tmpfiles-setup.serviceldconfiglooks for libraries in directories specified in/etc/ld.so.conf.d/*.conffilesTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.