Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model: set mtime of links to epoch to prevent spurious rebuilds #1808

Merged
merged 1 commit into from
Nov 10, 2021
Merged

model: set mtime of links to epoch to prevent spurious rebuilds #1808

merged 1 commit into from
Nov 10, 2021

Commits on Nov 8, 2021

  1. model: set mtime of links to epoch to prevent spurious rebuilds 

    We want to rebuild the model package when changing variants, but before
this change, we rebuild every time.  This happens because cargo detects
that the timestamps of the variant-sensitive links we create (and that
we tell it to watch) don't match its output file.  We don't control
creation of the output file, so they'll never match.  Each rebuild
changes the links again, causing another rebuild.

This change sets the mtime of the links to epoch, effectively telling
cargo that they haven't changed.  We still rebuild if the variant
changes, or if someone changes the links behind our back, which would
result in a different mtime.
    @tjkirch
    tjkirch committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    65bca26 View commit details
    Browse the repository at this point in the history