Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wicked: set ifup timeout #1800

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

jpculp
Copy link
Member

@jpculp jpculp commented Nov 2, 2021

Description of changes:

This bumps the wicked ifup timeout from the default 30s to 300s.

Testing done:

  • Build aws-k8s-1.20 x86_64 AMI and launch 30 instances.
  • Build vmware-k8s-1.21 x86_64 and join to VMware cluster.
  • Build aws-dev and launch VM that has no network interface. (thanks @bcressey!)

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jpculp
Copy link
Member Author

jpculp commented Nov 2, 2021

I'll pull this out of draft after #1798 is merged.

This bumps the wicked ifup timeout from the default 30s to 300s.
@jpculp jpculp changed the title wicked: set ifup timeout to infinite wicked: set ifup timeout Nov 3, 2021
@jpculp
Copy link
Member Author

jpculp commented Nov 3, 2021

  • Rebased
  • Switched new timeout from infinite to 300s.

Copy link
Contributor

@etungsten etungsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming testing vmware passes

@jpculp jpculp marked this pull request as ready for review November 3, 2021 01:13
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖌️

@bcressey
Copy link
Contributor

bcressey commented Nov 3, 2021

I've tested this using aws-dev under QEMU with a VM that had no network interface:

Nov 03 15:47:09 localhost systemd[1]: Starting wicked managed network interfaces...
[  303.310291] early-boot-config[1421]: Provider error: IMDS client failed: Error PUTing 'http://169.254.169.254/latest/api/token': error sending requ)
Nov 03 15:52:09 localhost wicked[1417]: eth0            no-device
Nov 03 15:52:09 localhost systemd[1]: Finished wicked managed network interfaces.
Nov 03 15:52:09 localhost systemd[1]: Reached target Network.
Nov 03 15:52:09 localhost systemd[1]: Reached target Network is Online.
Nov 03 15:52:09 localhost systemd[1]: Starting Bottlerocket userdata configuration system...
Nov 03 15:52:09 localhost early-boot-config[1421]: 15:52:09 [INFO] early-boot-config started
Nov 03 15:52:09 localhost early-boot-config[1421]: 15:52:09 [INFO] Retrieving platform-specific data
Nov 03 15:52:09 localhost early-boot-config[1421]: Provider error: IMDS client failed: Error PUTing 'http://169.254.169.254/latest/api/token': error s)
Nov 03 15:52:09 localhost systemd[1]: early-boot-config.service: Main process exited, code=exited, status=1/FAILURE

So this timeout works as expected, although the output is misleading since wicked is returning successfully even though the interface isn't up.

@jpculp jpculp merged commit 1dc31be into bottlerocket-os:develop Nov 4, 2021
@jpculp jpculp deleted the wicked-timeout branch November 4, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants