-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wicked: set ifup timeout #1800
wicked: set ifup timeout #1800
Conversation
I'll pull this out of draft after #1798 is merged. |
This bumps the wicked ifup timeout from the default 30s to 300s.
2d0591f
to
6793cdf
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming testing vmware passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🖌️
I've tested this using
So this timeout works as expected, although the output is misleading since |
Description of changes:
This bumps the wicked
ifup
timeout from the default 30s to 300s.Testing done:
aws-k8s-1.20
x86_64 AMI and launch 30 instances.vmware-k8s-1.21
x86_64 and join to VMware cluster.aws-dev
and launch VM that has no network interface. (thanks @bcressey!)Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.