Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GovCloud ECR account IDs #1793

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Add GovCloud ECR account IDs #1793

merged 1 commit into from
Nov 3, 2021

Conversation

WilboMo
Copy link
Contributor

@WilboMo WilboMo commented Oct 29, 2021

Issue number:
N/A

Description of changes:
Adds GovCloud accounts to schnauzer

Testing done:

  • Created EKS Test cluster in GovCloud
    • Launched AMI with changes and confirmed the following:
      • Could Join the cluster
      • Control-container functions as expected
      • Admin-container functions as expected
  • Created ECS Test cluster in GovCloud
    • Launched AMI with changes and confirmed the following:
      • Could Join the cluster
      • Control-container functions as expected
      • Admin-container functions as expected
  • Created EKS Test cluster in standard partition
    • Launched AMI with changes and confirmed the following:
      • Could Join the cluster
      • Control-container functions as expected
      • Admin-container functions as expected
  • Created ECS Test cluster in standard partition
    • Launched AMI with changes and confirmed the following:
      • Could Join the cluster
      • Control-container functions as expected
      • Admin-container functions as expected

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@tjkirch tjkirch changed the title Add ODT and PSU ECR accounts Add GovCloud ECR account IDs Oct 29, 2021
Add GovCloud ECR accounts
a035d17 
Adds accounts for GovCloud regions.
zmrow
zmrow approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦜

@zmrow zmrow merged commit 62a8db2 into bottlerocket-os:develop Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcressey bcressey bcressey approved these changes

@zmrow zmrow zmrow approved these changes

@webern webern webern approved these changes

@etungsten etungsten etungsten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WilboMo @bcressey @zmrow @webern @etungsten