Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add noProxy setting example #1765

Merged
merged 3 commits into from
Feb 1, 2022

Conversation

mrajashree
Copy link
Contributor

This PR updates the README to add an example for the format in which bottlerocket expects no-proxy setting to be specified

Issue number:

Description of changes:

Testing done:

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@mrajashree mrajashree changed the title Add noProxy setting example Docs: Add noProxy setting example Oct 1, 2021
Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @mrajashree! Would you be willing to add an example for https-proxy as well? Since they're related and sit right next to each other, that might be helpful.

@mrajashree
Copy link
Contributor Author

@tjkirch sure, updated it!

README.md Outdated Show resolved Hide resolved
Co-authored-by: Tom Kirchner <[email protected]>
@mrajashree
Copy link
Contributor Author

done @tjkirch

@etungsten etungsten requested review from cbgbt and zmrow February 1, 2022 18:33
@etungsten etungsten merged commit ff15b91 into bottlerocket-os:develop Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants