modify /etc/os-release #1749
Merged
modify /etc/os-release #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjkirch
approved these changes
Sep 14, 2021
This commit creates a VERSION field which is comprised of the VERSION_ID and the variant in parenthesis. The VERSION field replaces VERSION_ID in PRETTY_NAME.
jpculp
force-pushed
the
modify-os-release
branch
from
afd4fc4
to
3b2f6ab
Compare
|
Replaced the multiple echos with a single |
tjkirch
approved these changes
Sep 14, 2021
webern
approved these changes
Sep 15, 2021
bcressey
reviewed
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Adds HOME_URL, SUPPORT_URL, and BUG_REPORT_URL to
/etc/os-release,as well as the variant to the PRETTY_NAME and a new VERSION field.
OLD
NEW
Testing done:
Built and launched
aws-k8s-1.20andaws-ecs-1variants. Verified the expected changes via the admin container. Both instances connected to their respective clusters without issue, although the OS Image now reports asBottlerocket OS 1.2.0 (aws-k8s-1.20)in EKS.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.