k8s: update eni-max-pods #1724
Merged
k8s: update eni-max-pods #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmrow
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Thanks for doing this!
I pulled down the file from the associated PR on the EKS AMI repo and you've covered the diff here. 👍
🥇
|
Question for others - I don't foresee any issues with this, but perhaps we should hold off merging until the EKS PR gets approved and merged? Just in case there are any changes made over there? |
Add m6i instance types and others: fetched from https://github.com/awslabs/amazon-eks-ami/pull/749/files
|
@zmrow Hi, I found that https://github.com/awslabs/amazon-eks-ami/pull/749/files pr is merged, instead of previous one. I just force-pushed it. |
|
Thanks again! |
zmrow
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add m6i instance types and others: fetched from https://github.com/awslabs/amazon-eks-ami/pull/749/files
Issue number: #1720
Description of changes: Update eni-max-pods (add m6i instances)
Testing done: (none)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.