Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update references to the ECS variant for GA #1637

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

samuelkarp
Copy link
Contributor

Description of changes:
The ECS variant is no longer in preview. We've also launched a new optional Bottlerocket ECS Updater, similar to the Bottlerocket Update Operator for Kubernetes, which helps automate Bottlerocket updates.

Testing done:
No testing for doc updates.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
#### ECS variant

We currently have a single variant for Amazon ECS.
Newer LTS releases of the kernel may be introduced in newer variants, but not in the current one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can future-proof this with:

Suggested change
Newer LTS releases of the kernel may be introduced in newer variants, but not in the current one.
Newer LTS releases of the kernel may be introduced in newer variants, but not in older ones.

That's already what we use in the kubernetes section and we will have more ecs variants

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this from the Kubernetes text because we don't have more than one. "Older ones" didn't make sense to me.

Copy link

@Vaishvenk Vaishvenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for working on this.

@samuelkarp samuelkarp marked this pull request as ready for review June 30, 2021 17:51
README.md Outdated Show resolved Hide resolved
The ECS variant is no longer in preview.  We've also launched a new
optional Bottlerocket ECS Updater, similar to the Bottlerocket Update
Operator for Kubernetes, which helps automate Bottlerocket updates.
@samuelkarp samuelkarp merged commit 036ced8 into bottlerocket-os:develop Jun 30, 2021
@samuelkarp samuelkarp deleted the ecs-doc-updates branch June 30, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants