Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model-derive: add derive attributes at start of list #1572

Merged
merged 1 commit into from
May 13, 2021
Merged

model-derive: add derive attributes at start of list #1572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sources/models/model-derive/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ impl VisitMut for ModelHelper {
} else {
parse_quote!(#[derive(Debug, PartialEq, Serialize, Deserialize)])
};
node.attrs.push(attr);
// Rust 1.52 added a legacy_derive_helpers warning (soon to be an error) that yells if
// you use an attribute macro before the derive macro that introduces it. We should
// always put derive macros at the start of the list to avoid this.
node.attrs.insert(0, attr);
}

// Let the default implementation do its thing, recursively.
Expand Down