VMware: OVF template changes to support the vSphere CSI driver #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vSphere CSI driver requires that the hardware version for VMs is at least 15. This change updates the value in the OVF template.
The vSphere CSI driver requires that the `disk.EnableUUID` parameter be set to TRUE. This is necessary so VMDKs always present a consistent UUID to the VM so it is properly mounted.
The vSphere CSI driver recommends the VMware Paravirtual SCSI controller, and uses SCSI when attaching disks to VMs. We observed the BIOS prioritizes SCSI over NVME, so if a SCSI drive was attached using this CSI driver and the machine was rebooted, it would attempt to boot via the SCSI drive which obviously won't work. This change forces the BIOS to prioritize hdd nvme0:1 first.
etungsten
approved these changes
May 4, 2021
webern
approved these changes
May 4, 2021
zmrow
changed the title
bcressey
approved these changes
May 4, 2021
jpculp
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
These changes to the OVF template file are meant to support the vSphere CSI driver prerequisites. Additional details are in the commit messages below:
Testing done:
vmware-k8s-1.20node, booted to BIOS and observed the SCSI device comes before NVME in the boot order. Exited BIOS and the machine fell through to PXE, failing to boot.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.