Move pod-infra-container-image generation to schnauzer template helpers #1551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I made the pause-prefix code very similar to the existing ecr-prefix code, so if you expand the diff a little you'll see a good example. The regions/accounts were just a plain move, of course.
Testing done:
Before, the pause container ignored settings.aws.region. I launched a us-west-2 instance with settings.aws.region=ap-northeast-3 user data, and it still pulled from us-west-2.
After, it used my setting for ap-northeast-3, even though the instance was in us-west-2:
You can see that it generated the value correctly, and can see the new setting-generator and template:
(also tested normal health of instance)
Migration:
To test the migration, I started with a v1.0.8 instance built from a recent commit. (I didn't use the ap-northeast-3 user data when testing the migration.) You can see the original pause container, plus the setting-generator and (lack of) template:
I updated to a v1.1.0 build that included this change. The migration worked, fixing the setting-generator and adding the template:
I downgraded back to v1.0.8 and you can see the setting-generator was reverted and the template removed:
(I tested the health of the instance at all three points)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.