Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry builds on unexpected EOF error #1545

Closed

Conversation

bcressey
Copy link
Contributor

Issue number:
#1095

Description of changes:
This is a rare failure that we see in CI. Retry it so the entire run is not marked as failing.

Testing done:
Modified a package locally to emit "unexpected EOF" and exit non-zero. Observed that the build was retried ten times before buildsys finally gave up.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

This is a rare failure that we see in CI. Retry it so the entire run
is not marked as failing.

Signed-off-by: Ben Cressey <[email protected]>
@bcressey bcressey requested review from tjkirch and webern April 30, 2021 16:03
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link
Contributor

@arnaldo2792 arnaldo2792 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tools/buildsys/src/builder.rs Show resolved Hide resolved
@bcressey
Copy link
Contributor Author

bcressey commented May 4, 2021

@tjkirch carried this over the line in #1557.

@bcressey bcressey closed this May 4, 2021
@bcressey bcressey deleted the expect-the-unexpected-eof branch May 4, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants