systemd: generate stable machine IDs for VMWare guests #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Apr 29, 2021
Comment on lines
54
to
55
| + /* If we're running under VMWare, check for a machine ID | ||
| + * passed in via --uuid */ |
There was a problem hiding this comment.
I don't think this comment is accurate for VMWare.
There was a problem hiding this comment.
Also - the company styles it as VMware, let's follow suit. :)
packages/systemd/9009-machine-id-setup-generate-stable-ID-under-VMWare.patch
Outdated
Show resolved
Hide resolved
arnaldo2792
force-pushed
the
vmware-machine-id
branch
from
5c751ff
to
a1f7fc3
Compare
|
Systemd already has functionality to generate stable machine ids based on the virtualization type. This patch extends the functionality to check for the VMware value as well.
arnaldo2792
force-pushed
the
vmware-machine-id
branch
from
a1f7fc3
to
701ac2d
Compare
|
tjkirch
approved these changes
Apr 29, 2021
bcressey
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1536
Description of changes:
Systemd already has functionality to generate stable machine ids based on the virtualization type. This patch extends the functionality to check for the VMWare value as well.
Testing done:
In AWS dev, ecs, vmware-dev:
systemctl statusdidn't show any failuresjournalctl -p3didn't show any unexpected errorsAWS ECS c4.large (XEN)
AWS ECS m5.xlarge (KVM)
AWS ECS t4g.medium (KVM aarch64)
VMWare
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.