Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a friendly name for OVAs #1535

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

bcressey
Copy link
Contributor

Issue number:
Fixes #1528

Description of changes:
This makes OVA building a mandatory step and stores the output with other variant artifacts.

Convenience symlinks are created in "latest", along with a symlink that's used to give the repo artifact a friendly, predictable name.

Since the archives directory is no longer in use, remove it from the setup and cleanup steps.

Testing done:
Built the vmware-dev variant.

❯ ls -latr build/images/x86_64-vmware-dev/latest/*.ova
lrwxrwxrwx. 1 fedora fedora 58 Apr 28 23:14 build/images/x86_64-vmware-dev/latest/bottlerocket-vmware-dev-x86_64.ova -> ../bottlerocket-vmware-dev-x86_64-1.0.8-bab170a6-dirty.ova
lrwxrwxrwx. 1 fedora fedora 58 Apr 28 23:14 build/images/x86_64-vmware-dev/latest/bottlerocket-vmware-dev-x86_64-v1.0.8.ova -> ../bottlerocket-vmware-dev-x86_64-1.0.8-bab170a6-dirty.ova

❯ ls -latr build/images/x86_64-vmware-dev/*.ova
-rw-rw-r--. 1 fedora fedora 216360960 Apr 28 23:14 build/images/x86_64-vmware-dev/bottlerocket-vmware-dev-x86_64-1.0.8-bab170a6-dirty.ova

Built the repo.

❯ ls -latr build/repos/default/bottlerocket-1.0.8-bab170a6-dirty/targets/*.ova
lrwxrwxrwx. 1 fedora fedora 105 Apr 28 23:17 build/repos/default/bottlerocket-1.0.8-bab170a6-dirty/targets/11be8b032ef2092662589c9b6f5afe136466f75a1857c57e509d3baae3f6f6bd.bottlerocket-vmware-dev-x86_64-v1.0.8.ova -> /home/fedora/bottlerocket/build/images/x86_64-vmware-dev/latest/bottlerocket-vmware-dev-x86_64-v1.0.8.ova

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

This makes OVA building a mandatory step and stores the output with
other variant artifacts.

Convenience symlinks are created in "latest", along with a symlink
that's used to give the repo artifact a friendly, predictable name.

Since the archives directory is no longer in use, remove it from the
setup and cleanup steps.

Signed-off-by: Ben Cressey <[email protected]>
@bcressey bcressey requested review from tjkirch and zmrow April 28, 2021 23:29
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧄

Yay - thanks for doing this!

@bcressey bcressey merged commit 66eef8b into bottlerocket-os:develop Apr 29, 2021
@bcressey bcressey deleted the friendly-ova-name branch April 29, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VMware: include a "friendly" named OVA in the TUF repo
3 participants