Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VMware spelling and document user data sources #1534

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

zmrow
Copy link
Contributor

@zmrow zmrow commented Apr 28, 2021

Issue number:
N/A

Description of changes:
This change fixes the spelling of VMware and documents user data sources for vmware-dev

commit 1c9409ee145729b6966441acefe18c5432e086d8
    early-boot-config: Fix VMware spelling

commit 3ecb33d7252d503bd439012a2870ee307ea8f421
    vmware-dev: Document user data sources

commit 012712a79bbd799fe80dea6f884e08c1f787625a
    vmware-dev: Fix VMware spelling

Testing done:
Booted a vmware-dev VM with user data to ensure nothing is broken there.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@zmrow zmrow changed the title vmware-dev: Fix VMWare spelling and document user data sources vmware-dev: Fix VMware spelling and document user data sources Apr 28, 2021
sources/models/README.md Show resolved Hide resolved
variants/README.md Show resolved Hide resolved
@zmrow zmrow changed the title vmware-dev: Fix VMware spelling and document user data sources Fix VMware spelling and document user data sources Apr 29, 2021
@zmrow
Copy link
Contributor Author

zmrow commented Apr 29, 2021

^ Addresses @tjk's comments:

  • Split the spelling and user data documentation into 2 commits
  • Adds a new commit for the spelling updates in early-boot-config

@zmrow zmrow self-assigned this Apr 29, 2021
@zmrow zmrow merged commit 96f2d33 into bottlerocket-os:develop Apr 29, 2021
@zmrow zmrow deleted the vmwdev-fixup branch April 29, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants