Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "aws-k8s-1.20: enable unified cgroup hierarchy" #1533

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

etungsten
Copy link
Contributor

@etungsten etungsten commented Apr 28, 2021

Issue number:
N/A

Description of changes:

Author: Erikson Tung <[email protected]>
Date:   Wed Apr 28 14:18:54 2021 -0700

    Revert "aws-k8s-1.20: enable unified cgroup hierarchy"
    
    This reverts commit 07f5e84dd8e3643c09f6cc9c19af21dd48b82956.
    
    k8s+containerd with cgroup v2 is currently not working correctly
    due to https://github.com/opencontainers/runc/issues/2366

Testing done:
Launched node, joins cluster fine, can run pods

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

This reverts commit 07f5e84.

k8s+containerd with cgroup v2 is currently not working correctly
due to opencontainers/runc#2366
Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming testing is OK, but I can't see how it wouldn't be.

@etungsten etungsten marked this pull request as ready for review April 28, 2021 22:17
@etungsten etungsten merged commit 9794c29 into bottlerocket-os:develop Apr 28, 2021
@etungsten etungsten deleted the revert-cgroupv2 branch April 28, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants