Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add open-vm-tools and dependencies #1529

Merged
merged 8 commits into from
May 3, 2021

Conversation

bcressey
Copy link
Contributor

Issue number:
Fixes #1510

Description of changes:
Add open-vm-tools and its dependencies: glib2, libffi, libtirpc.

Make a minor fix to the libmount package in util-linux to correctly express development dependencies.

Adjust libdbus build to work correctly if libselinux-devel is present in the SDK.

Update to a newer SDK that contains glib-genmarshal and genrpc.

Testing done:
Built the vmware-dev image. Verified that the DNS name and IP addresses are visible in vCenter, and that VMWare Tools reports as running.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@bcressey bcressey force-pushed the open-vm-tools branch 2 times, most recently from e1e8aad to e799a84 Compare April 28, 2021 20:28
@bcressey
Copy link
Contributor Author

(fix merge conflict with kernel 5.10 update)

@bcressey
Copy link
Contributor Author

Added configuration for vmtoolsd, so that restarting the VM from vCenter works as expected.

variants/Cargo.lock Show resolved Hide resolved
packages/libglib/libglib.spec Show resolved Hide resolved
packages/open-vm-tools/vmtoolsd.service Show resolved Hide resolved
packages/open-vm-tools/open-vm-tools.spec Outdated Show resolved Hide resolved
packages/open-vm-tools/open-vm-tools.spec Show resolved Hide resolved
packages/open-vm-tools/open-vm-tools.spec Outdated Show resolved Hide resolved
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@bcressey
Copy link
Contributor Author

Fixes per review feedback

@bcressey
Copy link
Contributor Author

TODO: add vmtoolsd to the list of affected services.

Otherwise, the build fails if libselinux-devel is present in the SDK.

Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
libmount depends on libblkid.

Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
@bcressey
Copy link
Contributor Author

(rebase with no changes to these commits)

@bcressey bcressey marked this pull request as ready for review April 30, 2021 22:19
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚙️

@bcressey bcressey merged commit 3ee53ce into bottlerocket-os:develop May 3, 2021
@bcressey bcressey deleted the open-vm-tools branch May 3, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VMWare: Run open-vm-tools to report guest information to vSphere
4 participants