-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: add setting for configuring registryPullQPS and registryBurst #1527
Conversation
8bdb5f2
to
52e3821
Compare
I realized that 1.20 had been added, and I will update it |
52e3821
to
cbc1efe
Compare
Pushing above add settings to kubernetes 1.20. |
cbc1efe
to
5c5d8ad
Compare
Push above fix rebase problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided the i32
/u32
bit is fixed - this looks good!
🐝
pass registry-qps argument to kubelet
pass registry-burst argument to kubelet
Adds a migration for two new settings `settings.kubernetes.registry-qps` and `settings.kubernetes.registry-burst`
5c5d8ad
to
3b7c693
Compare
Push above update data type from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍭
Issue number:
#1495
Description of changes:
Adds two new settings
kubernetes.registry-qps
andkubernetes.resgitry-burst
for configuringTesting done:
registry-qps
Setting
registry-qps
to lowest value (1). and lauching/pulling a number of pods/containers that exceed the image pulling QPS to trigger ErrorErrImagePull - pull QPS exceeded
Fist step: Test Default value (5)
Test with default value to make sure test result only can be affected by
registry-qps
Lauching 12 pods/containers simultaneously
All pods/containers have been created succesfully, which is expected.
Second step: Test Lowest value (1)
Test with lowest value (1) to makre sure Error
ErrImagePull - pull QPS exceeded
will be triggered because of inadequate QPS valueSetting
registry-qps
to lowest value, which is 1.Lauching 12 pods/containers simultaneously
Error
ErrImagePull - pull QPS exceeded
has been triggerred, which meansregistry-qps = 1
succussfully limits pulling images.registry-burst
Setting
registry-burst
to lowest value (1). and lauching/pulling a number of pods/containers that exceed the image pulling QPS to trigger ErrorErrImagePull - pull QPS exceeded
Fist step: Test Default value (10)
Test with default value to make sure test result only can be affected by
registry-burst
Lauching 7 pods/containers simultaneously
All pods/containers have been created succesfully, which is expected.
Second step: Test Lowest value (1)
Test with lowest value (1) to makre sure Error
ErrImagePull - pull QPS exceeded
will be triggered because of inadequate QPS valueSetting
registry-burst
to lowest value, which is 1.Lauching 7 pods/containers simultaneously
Error
ErrImagePull - pull QPS exceeded
has been triggerred, which meansregistry-burst = 1
succussfully limits pulling images.Migration test
upgrade and downgrade
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.