Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: build zlib and zlib-devel #1523

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

arnaldo2792
Copy link
Contributor

Issue number:
N / A

Description of changes:

6bd13fa5 packages: build zlib and zlib-devel

This commit adds zlib runtime libraries and development headers

Testing done:

  • Build vmware-dev variant and confirm the new libraries are in /usr/lib, the snapshot is the output of a VMWare host:

image

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
variants/vmware-dev/Cargo.toml Outdated Show resolved Hide resolved
packages/libz/Cargo.toml Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
@arnaldo2792
Copy link
Contributor Author

  • Addressed all the nits
  • Removed Boost from the licenses list
  • Removed unused environment variables
  • Switch to use the xz file instead of gz

@arnaldo2792
Copy link
Contributor Author

  • Re-added set_env macro to setup environment variables
  • Removed dependency from vmware-dev variant
  • Removed Boost license comment

variants/vmware-dev/Cargo.toml Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
@arnaldo2792
Copy link
Contributor Author

  • Use the %make_install macro
  • Remove comment explaining the use of CROSS_PREFIX
  • Fixed funky Cargo.toml formatting

packages/libz/libz.spec Outdated Show resolved Hide resolved
packages/libz/libz.spec Outdated Show resolved Hide resolved
This commit adds zlib runtime libraries and development headers
@arnaldo2792
Copy link
Contributor Author

  • Remove unnecessary DESTDIR=
  • Fix typo in comment

@arnaldo2792 arnaldo2792 merged commit 70f1492 into bottlerocket-os:develop Apr 27, 2021
@arnaldo2792 arnaldo2792 deleted the add-libz branch April 27, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants