Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECR account IDs for ap-northeast-3: Osaka #1504

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Apr 19, 2021

Issue number:

This is the main bit for #1474 but it won't be done until we perform a release and update the docs accordingly.

Description of changes:

60924ea8 Add ECR account IDs for ap-northeast-3: Osaka
c7a7f1a9 pluto: remove duplicate eu-south-1 region entry

Testing done:

I made a temporary change to pluto to force the ap-northeast-3 region instead of using IMDS or the fallback. (I'm working on a separate change to use settings.aws.region instead of IMDS so we can test more easily.) It fetched the containers from ap-northeast-3 OK, from an instance in us-west-2:

host-ctr[3724]: time="2021-04-19T23:08:02Z" level=info msg="pulling with Amazon ECR Resolver" ref="ecr.aws/arn:aws:ecr:ap-northeast-3:602401143452:repository/eks/pause-amd64:3.1"
host-ctr[3533]: time="2021-04-19T23:08:02Z" level=info msg="pulling with Amazon ECR Resolver" ref="ecr.aws/arn:aws:ecr:ap-northeast-3:328549459982:repository/bottlerocket-control:v0.5.0"
host-ctr[3518]: time="2021-04-19T23:08:02Z" level=info msg="pulling with Amazon ECR Resolver" ref="ecr.aws/arn:aws:ecr:ap-northeast-3:328549459982:repository/bottlerocket-admin:v0.7.0"
host-ctr[3724]: time="2021-04-19T23:08:04Z" level=info msg="pulled image successfully" img="ecr.aws/arn:aws:ecr:ap-northeast-3:602401143452:repository/eks/pause-amd64:3.1"
host-ctr[3724]: time="2021-04-19T23:08:04Z" level=info msg="unpacking image..." img="ecr.aws/arn:aws:ecr:ap-northeast-3:602401143452:repository/eks/pause-amd64:3.1"
host-ctr[3724]: time="2021-04-19T23:08:04Z" level=info msg="tagging image" img="602401143452.dkr.ecr.ap-northeast-3.amazonaws.com/eks/pause-amd64:3.1"
host-ctr[3518]: time="2021-04-19T23:08:10Z" level=info msg="pulled image successfully" img="ecr.aws/arn:aws:ecr:ap-northeast-3:328549459982:repository/bottlerocket-admin:v0.7.0"
host-ctr[3518]: time="2021-04-19T23:08:10Z" level=info msg="unpacking image..." img="ecr.aws/arn:aws:ecr:ap-northeast-3:328549459982:repository/bottlerocket-admin:v0.7.0"
host-ctr[3533]: time="2021-04-19T23:08:10Z" level=info msg="pulled image successfully" img="ecr.aws/arn:aws:ecr:ap-northeast-3:328549459982:repository/bottlerocket-control:v0.5.0"
host-ctr[3533]: time="2021-04-19T23:08:10Z" level=info msg="unpacking image..." img="ecr.aws/arn:aws:ecr:ap-northeast-3:328549459982:repository/bottlerocket-control:v0.5.0"
host-ctr[3518]: time="2021-04-19T23:08:15Z" level=info msg="tagging image" img="328549459982.dkr.ecr.ap-northeast-3.amazonaws.com/bottlerocket-admin:v0.7.0"
host-ctr[3533]: time="2021-04-19T23:08:15Z" level=info msg="tagging image" img="328549459982.dkr.ecr.ap-northeast-3.amazonaws.com/bottlerocket-control:v0.5.0"

Still ran a pod OK, admin and control containers worked OK, systemctl status running, API OK.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@tjkirch tjkirch merged commit 708d095 into bottlerocket-os:develop Apr 20, 2021
@tjkirch tjkirch deleted the osaka branch April 20, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants