Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrations: admin-container v0.7.0 default version migration #1443

Merged

Conversation

jpculp
Copy link
Member

@jpculp jpculp commented Apr 2, 2021

Issue number:

N/A

Description of changes:

Migrates default version of admin container from v0.6.0 to v0.7.0

Testing done:

Using a custom TUF repo, I upgraded and downgraded between 1.0.7 and 1.0.8 and verified the container version change.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just waiting for testing/rebase.

@webern webern self-requested a review April 5, 2021 20:12
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚈

Once testing is completed, I'm good.

@tjkirch tjkirch added this to the 1.0.8 milestone Apr 7, 2021
Migrates default version of admin container from v0.6.0 to v0.7.0
@jpculp jpculp force-pushed the admin-container-migrate-v0.7.0 branch from ce6db79 to f4eda0e Compare April 7, 2021 21:32
@jpculp
Copy link
Member Author

jpculp commented Apr 7, 2021

  • Tested upgrade/downgrade.
  • Re-based and fixed merge conflicts.

@jpculp jpculp marked this pull request as ready for review April 7, 2021 21:34
@jpculp jpculp requested a review from tjkirch April 7, 2021 21:34
@jpculp jpculp merged commit 53e9826 into bottlerocket-os:develop Apr 7, 2021
@jpculp jpculp deleted the admin-container-migrate-v0.7.0 branch April 7, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants