Add support for specifying a variant's supported architectures #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Mar 31, 2021
webern
approved these changes
Mar 31, 2021
|
^ addresses @bcressey 's comments |
|
The build now stops before it tries to build packages if the current variant's supported architectures doesn't support the current architecture. |
jpculp
approved these changes
Apr 1, 2021
bcressey
reviewed
Apr 1, 2021
tjkirch
reviewed
Apr 1, 2021
This change adds an additional key that can be specified in a variant's `Cargo.toml`, `supported-arches`. It is a list and the supported enum values are `x86_64` and `aarch64`. If `supported-arches` is specified, the current `BUILDSYS_ARCH` is checked against the list. If `supported-arches` is not specified, the build continues as before.
This change adds the `supported-arch` key to `vmware-dev`'s `Cargo.toml` and ensure's the variant will only be built for `x86_64`.
|
^ Addresses the comments! |
tjkirch
approved these changes
Apr 1, 2021
bcressey
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #1404
Related to #1393
Description of changes:
Testing done:
aws-k8s-1.18image for bothx86_64andaarch64vmware-devforx86_64vmware-devforaarch64and it correctly failsTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.