Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse-datetime: removed generate_constants logic from build.rs #1376

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

jpculp
Copy link
Member

@jpculp jpculp commented Mar 10, 2021

Issue number:

N/A

Description of changes:

Modified the build.rs to remove the extraneous generate_constants logic.

Testing done:

  • Built aws-ecs-1 ami and launched instance.
  • Instance connected to ecs cluster.
  • Test task deployed successfully.
  • Connected via ssm session.
  • Enabled and launched admin container.
  • Connected to admin container and ran sudo sheltie to verify root shell was still available.
  • Checked for failed systemd units.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Modified the build.rs to remove the extraneous generate_constants logic.
@jpculp jpculp requested review from tjkirch and zmrow March 10, 2021 01:59
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍔

@jpculp jpculp merged commit 921d24a into bottlerocket-os:develop Mar 11, 2021
@jpculp jpculp deleted the parse-datetime-build-fix branch March 11, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants