model: don't include metrics defaults in vmware-dev #1365
Conversation
The vmware-dev model doesn't have settings.metrics because metricdog currently relies on settings.aws.region. If we update metricdog to support other platforms and decide we want metrics there, we can link in this new metrics.toml file. Even then, it's useful to have separated in case other people build variants where they don't want to send metrics.
|
In my work-in-progress branch for a It felt like an error to me that Here, I like the refactoring to make metrics optional, but I want us to figure out what the off-AWS, on-prem story should be. Perhaps we can defer that until the |
I think in the long run it's an error, but at the present time we can't include it because metricdog doesn't support other platforms yet. I think we're planning on fixing that soon.
I think we should - it's a useful signal for the health of our components, which differ slightly in presence and composition across variants. I think we should work toward fixing metricdog rather than removing it in aws-dev.
I agree. I consider this a build fix, though, since vmware-dev can't run at all right now. @bcressey Are you OK with approving this to fix the build, and discussing future paths for metrics separately? |
|
As per offline conversation, I'd vote for a "global" region until we know of something better. |
Description of changes:
Testing done:
In the vmware-dev variant, before the change, you would receive repeated messages on the console about not being able to deserialize settings because "settings.metrics" is unknown.
After, vmware-dev launches and runs fine, with no warnings, settings look good.
I also tested aws-k8s-1.17 and aws-ecs-1. Both launched and ran pods/tasks successfully.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.