host-ctr: specify non-colliding runc root #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runc root directory is used for storing state needed by the runtime shim. By default, this is /run/containerd/runc. Since we configure host containers to use /run/host-containerd instead of /run/containerd, this change allows all host container state to be inside /run/host-containerd.
samuelkarp
force-pushed
the
host-ctr-runc-root
branch
from
834152b
to
b22168e
Compare
tjkirch
approved these changes
Feb 27, 2021
bcressey
approved these changes
Feb 27, 2021
etungsten
approved these changes
Feb 27, 2021
webern
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The runc root directory is used for storing state needed by the runtime shim. By default, this is /run/containerd/runc. Since we configure host containers to use /run/host-containerd instead of /run/containerd, this change allows all host container state to be inside /run/host-containerd.
Testing done:
Built an
aws-ecs-1AMI and launched it. Verified that the host containers (bothcontrolandadmin) now had theirstate.jsonfiles stored in/run/host-containerd/runc/default/{admin,control}. Verified that I could run containers manually withctrand their state was kept in/run/containerd/runc/default/$id. Verified that I could run containers manually with Docker and that their files were unaffected at/run/docker/runtime-runc/moby.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.