add support for kubelet in standalone mode and TLS auth #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a systemd drop-in file for the kubelet args, we can control them using a template, while leaving the main service unit in place for dependency resolution. Signed-off-by: Ben Cressey <[email protected]>
|
Now I see why you knew about the |
|
He does grow a pretty healthy mustache.... 🤔 |
zmrow
reviewed
Feb 22, 2021
etungsten
approved these changes
Feb 22, 2021
tjkirch
approved these changes
Feb 22, 2021
This also makes the API server, cluster name, and cluster certificate settings optional, since the kubelet does not need these values when running in standalone mode. Signed-off-by: Ben Cressey <[email protected]>
This enables the kubelet to use TLS for authentication instead of AWS role credentials. If a bootstrap token is provided, the kubelet will use it to perform TLS bootstrapping. Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
bcressey
force-pushed
the
standalone-mode
branch
from
4a40314
to
762a4bb
Compare
tjkirch
approved these changes
Feb 22, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Refactored handling of kubelet args so they can be templated. Added support for "standalone" mode, where the kubelet is started without a kubeconfig file and does not connect to an API server.
Testing done:
Verified that 1.18 and 1.19 nodes came up with the expected defaults: standalone mode off, AWS authentication on.
Launched 1.15, 1.16, 1.17, 1.18, and 1.19 in standalone mode running a static redis pod. Confirmed that kubelet started correctly and brought up redis.
Launched 1.15, 1.16, 1.17, 1.18, and 1.19 in TLS authentication mode with a bootstrap token to join a cluster provisioned by the Cluster API Provider for AWS (CAPA). All nodes joined.
(Nodes are in
NotReadystatus because I haven't set up a CNI plugin.)Tested upgrade and downgrade from 1.0.5 into 1.0.6 with the migrations. Verified that new settings were removed and old lists restored on downgrade.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.