Add the ability to output vmdk via qemu-img #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpculp
commented
Jan 22, 2021
jahkeup
suggested changes
Jan 22, 2021
bcressey
requested changes
Jan 23, 2021
zmrow
suggested changes
Jan 26, 2021
bcressey
reviewed
Jan 28, 2021
bcressey
reviewed
Jan 29, 2021
This change allows users to edit the metadata in a variant's cargo.toml to output a vmdk through buildsys via qemu-img.
Double quotes were added to several places in rpm2img to further prevent unwanted globbing and word splitting (SC2086).
jahkeup
approved these changes
Jan 29, 2021
bcressey
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
This change allows users to edit the metadata in a variant's cargo.toml to output an OVA compatible vmdk through buildsys via qemu-img.
Double quotes were also added to several places in rpm2img to prevent unwanted globbing and word splitting (SC2086).
Testing done:
Built aws-k8s-1.18 variant with no toml changes and received the standard img.lz4 output.
Built aws-k8s-1.18 variant with
image-format = "vmdk"added to the toml and received stream-optimized vmdk output for bottlerocket-aws-k8s-1.18-aarch64 and bottlerocket-aws-k8s-1.18-aarch64-data.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.