enable early LSM support for lockdown #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the Lockdown LSM wasn't actually consulted
for security decisions, because it does not appear in the CONFIG_LSM
list.
As an alternative, we could override CONFIG_LSM to add lockdown:
CONFIG_LSM="lockdown,yama,loadpin,safesetid,integrity,
selinux,smack,tomoyo,apparmor"
However, then that list would need to be maintained when updating the
kernel, or any new LSMs would be quietly ignored.
Enabling early LSM support resolves the issue, and makes it possible
for custom builds to specify the desired lockdown state on the kernel
command line.
Signed-off-by: Ben Cressey <[email protected]>
etungsten
approved these changes
Jan 13, 2021
webern
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Initialize the lockdown LSM early, in case a custom build specifies
lockdown=integrityor similar on the kernel command line.This also ensures that the lockdown LSM is consulted for policy decisions, which it previously was not because it was not listed in
CONFIG_LSM.Testing done:
Verified that unsigned kernel modules cannot be loaded after enabling "integrity" mode:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.