pubsys: fix kms signing issue #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update coldsnap to v0.2.0 and set it to use rustls. This is a necessary prerequisite of any tough-related updates. When we update tough, then coldsnap and rough will both resolve to rusoto 0.45 and their feature selections will conflict. By bumping coldsnap and setting it to rustls, we are now able to update tough, tough-kms, or tough-ssm. This commit also explicitly sets the rusoto crates to use rustls. This was also found to be necessary when newer versions of tough* are introduced.
bcressey
approved these changes
Nov 12, 2020
This commit fixes an occasional issue where a KMS-signed repo could not be loaded. The fix is in tough-kms v0.1.1.
Remove the caret from the tough-kms version, it doesn't do anything. |
zmrow
approved these changes
Nov 12, 2020
|
With the fix the automation hasn't failed since late yesterday (approximately 14 hours ago). It resigns 23 repositories every 20 minutes. So that's 966 repo resigns without fail. Each resign is resigning 3 metadata files. So that's 2898 produced signatures. |
etungsten
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
awslabs/tough#262
Description of changes:
In
pubsys:Testing done:
cargo make repoworks with a KMS key when creating a new repo.cargo make amiworks with the new coldsnap version.cargo make repoworks with a KMS key when updating an existing repo.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.