Adds rtcsync directive to chrony config file #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This directive enables kernel synchronisation (every 11 minutes) of the real-time clock. It also causes chrony to update the timex sync flag, which is commonly used to monitor clock synchronisation, e.g. via the prometheus node exporter. Fixes bottlerocket-os#1183
|
This looks reasonable to me, but... paging @bcressey |
bcressey
approved these changes
Oct 26, 2020
|
LGTM, thanks! |
webern
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #1183
Description of changes:
Adds the
rtcsyncdirective to the chrony config file.I think this is a resonable change to make, as it allready seems to be the default in Amazon Linux 2.
Testing done:
I have added this directive to the config file on a running instance and restarted chronyd, and observed that the value of
node_timex_syncexported by the prometheus node exporter is 1.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.