Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align opt-level for crate build deps #1155

Merged
merged 2 commits into from
Oct 12, 2020
Merged

align opt-level for crate build deps #1155

merged 2 commits into from
Oct 12, 2020

Commits on Oct 9, 2020

  1. Revert "actions: Force Rust 1.46.0 temporarily" 

    This reverts commit 7fc8620.
    @bcressey
    bcressey committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    422f8a9 View commit details
    Browse the repository at this point in the history

  2. build: align opt-level for crate build deps 

    Our OS packages are built as a byproduct of build script execution,
while the final Rust artifacts are largely ignored.

Since Rust 1.47.0, cargo builds host dependencies like build scripts
with opt-level "0" by default, which did not match the "z" level we
picked to minimize the size of the output artifacts.

This caused package build dependencies to be built more than once,
with concurrent Docker builds for the same package. This is wasteful
and creates races that our build tool does not handle gracefully.

By aligning the opt-level we restore the previous behavior.

Signed-off-by: Ben Cressey <[email protected]>
    @bcressey
    bcressey committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    3e75f29 View commit details
    Browse the repository at this point in the history