Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Update method recommendation #1127

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

etungsten
Copy link
Contributor

This PR attempts to address #1124 (comment), #1124 (review)

Issue number:
N/A

Description of changes:

Author: Erikson Tung <[email protected]>
Date:   Tue Sep 22 13:26:38 2020 -0700

    ECS README: fixes broken link in ECS quickstart
    
    Fixes a broken link in the ECS quickstart. Now the link links to the ECS
    variant's Cargo.toml

Author: Erikson Tung <[email protected]>
Date:   Tue Sep 22 13:41:16 2020 -0700

    README: recommend update methods for EKS and ECS variants

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@etungsten etungsten changed the title Update recommendation README: Update method recommendation Sep 22, 2020
QUICKSTART-ECS.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@etungsten
Copy link
Contributor Author

Push above addresses review comments by @tjkirch

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎃

@etungsten etungsten merged commit 503db74 into bottlerocket-os:develop Sep 24, 2020
@etungsten etungsten deleted the update-recommendation branch September 24, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants