pass Go module proxy variables through docker-go #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelkarp
reviewed
Sep 15, 2020
Previously, we always set `GOPRIVATE=*`, which blocked any use of the public Go module mirror. Now we pass the module proxy variables through from the environment, so that the behavior is under the developer's control.
bcressey
force-pushed
the
no-goprivate
branch
from
c961600
to
c5f3397
Compare
samuelkarp
approved these changes
Sep 16, 2020
iliana
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Previously, we always set
GOPRIVATE=*, which blocked any use of the public Go module mirror.Now we pass the module proxy variables through from the environment, so that the behavior is under the developer's control.
Testing done:
None, yet.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.