Makefile.toml: clean up clean actions #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The directory is no longer created after 5e4cf98.
This allows cleaning images, which take up the most space, without cleaning up packages, which take a lot less space but a lot more time to rebuild.
It was removing all artifacts inside and leaving an empty directory, which doesn't match the behavior of the other clean tasks.
It was removing all artifacts inside and leaving an empty directory, which doesn't match the behavior of the other clean tasks.
webern
approved these changes
Aug 28, 2020
bcressey
reviewed
Aug 29, 2020
|
^ This new commit makes |
bcressey
approved these changes
Aug 31, 2020
samuelkarp
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
My overall goal was adding
clean-imagesas a quick way to save space from large objects that are easily rebuilt. The other commits are cleanup around the "clean" space.Testing done:
Added
set -xand ran each task individually, and the overallcleantask, and saw the separated commands run OK.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.