Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel describe #1086

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Aug 27, 2020

Description of changes:

Add info logging before service requests to help explain timing
pubsys: check for copied AMIs in parallel
    
We were waiting on the get_ami_id calls serially which led to an unnecessary
increase in runtime when we increase region count.

Testing done:

Before, it takes 16 seconds for 16 regions consistently, with less information shown:

18:45:48 [INFO] Found ami-12345 available in us-west-2
18:46:04 [INFO] Starting copy from us-west-2 to ap-northeast-1

After, it takes 7 seconds for 16 regions consistently, and shows useful information between calls:

19:06:43 [INFO] Found ami-23456 available in us-west-2
19:06:43 [INFO] Getting account IDs for target regions so we can grant access to copy source AMI
19:06:46 [INFO] Checking whether AMIs already exist in target regions
19:06:50 [INFO] Starting copy from us-west-2 to ap-northeast-1

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

tjkirch and others added 2 commits August 27, 2020 12:09
We were waiting on the get_ami_id calls serially which led to an unnecessary
increase in runtime when we increase region count.

Co-authored-by: Zac Mrowicki <[email protected]>
Co-authored-by: Tom Kirchner <[email protected]>
@tjkirch tjkirch requested a review from zmrow August 27, 2020 19:13
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇶🇦

@tjkirch tjkirch merged commit aa6eaf1 into bottlerocket-os:develop Aug 31, 2020
@tjkirch tjkirch deleted the parallel-describe branch August 31, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants