revise security guidance #1072
Merged
revise security guidance #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelkarp
reviewed
Aug 24, 2020
bcressey
force-pushed
the
security-docs
branch
from
86d3f9a
to
35627ec
Compare
tjkirch
approved these changes
Aug 25, 2020
webern
approved these changes
Aug 25, 2020
Strengthen the warning against privileged containers, since they can bypass other protection mechanisms such as SELinux in various ways. Upgrade the warning against sharing host namespaces, and clarify the additional risk of sharing the host PID namespace. Expand the section on system mounts to cover local storage concerns. Mention the new `control_t` label for API socket access, and the path to the Docker runtime socket at `/run/docker.sock`. Add example for Amazon ECS. Signed-off-by: Ben Cressey <[email protected]>
bcressey
force-pushed
the
security-docs
branch
from
35627ec
to
f500fb6
Compare
samuelkarp
approved these changes
Aug 25, 2020
jhaynes
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Strengthen the warning against privileged containers, since they can bypass other protection mechanisms such as SELinux in various ways.
Upgrade the warning against sharing host namespaces, and clarify the additional risk of sharing the host PID namespace.
Expand the section on system mounts to cover local storage concerns.
Mention the new
control_tlabel for API socket access, and the path to the Docker runtime socket at/run/docker.sock.Testing done:
Rendered locally with
grip.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.