Added patch for EC2 IMDSv2 support in Docker #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelkarp
reviewed
Aug 20, 2020
tjkirch
reviewed
Aug 20, 2020
srgothi92
changed the title
tjkirch
reviewed
Aug 20, 2020
tjkirch
reviewed
Aug 21, 2020
* Fixed peer review comments * Changed url paramter to actual patch external URL
tjkirch
approved these changes
Aug 21, 2020
samuelkarp
approved these changes
Aug 21, 2020
|
Changed the URL parameter in Cargo.toml to actual external patch URL. Retested with the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Used Look aside cache for caching awslogs_update_aws-sdk-go_to_support_imdsv2.patch
Applied the patch to docker-engine for EC2 IMDSv2 support in Docker
Testing done:
awslogsLog driver.--metadata-options "HttpEndpoint=enabled,HttpTokens=required"v1 disabled. Task Stopped on 1st instance but ran successfully on 2nd instance.MetadataNoTokento zero for 2nd Instance.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.