aws-ecs-1: remove unsupported capabilities #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the ECS agent adds several capabilities for features that are non-functional on Bottlerocket. This patch removes those capabilities until we add support for the associated features.
tjkirch
approved these changes
Aug 19, 2020
webern
approved these changes
Aug 19, 2020
Enabling each capability looks like a good chunk of work - I think an issue to drive/track each seems appropriate. Are there some issues already? If not, would you create a few issues to track the disabled capabilities and to collect your thoughts on how you'd likely approach them? |
jahkeup
approved these changes
Aug 19, 2020
Agreed! I won't be able to get that done for a bit, but it's on my TODO list now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#815
Description of changes:
By default, the ECS agent adds several capabilities for features that are non-functional on Bottlerocket. This patch removes those capabilities until we add support for the associated features.
Testing done:
Built an AMI. Examined the list of capabilities with
amazon-ecs-agent -ecs-attributes(through sheltie) and by calling the DescribeContainerInstances API.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.