-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: upgrade to 19.03.12 #1025
Conversation
{ path = "LICENSE", hash = 0xcdf3ae00}, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits: lost final newline, and space before }
%global rpmver %{gover} | ||
%global gitrev 9dc6525e6118a25fab2be322d1914740ea842495 | ||
|
||
%global source_date_epoch 1363394400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this timestamp come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is, as near as I can tell, Docker's birthday. (The date and time of this talk.)
|
Discussed with @bcressey offline; we believe the change in behavior is fine for now, it ends up with strictly more-compatible behavior for the case where |
Description of changes:
Upgrade docker-engine and docker-cli to 19.03.12.
Testing done:
Built and ran both the
aws-dev
andaws-ecs-1
variants. Both variants are able to run containers.docker version
output looks reasonable.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.