Fix warnings for use of deprecated items in common_migrations #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The singular `AddSettingMigration` and `RemoveSettingMigration` exist for backward compatibility and are marked deprecated. The trait implementations on those items have to reference the deprecated items, of course, but this triggers compiler warnings about use of the deprecated items. We only want warnings when people are actively using these types outside of the module that defines them; we don't want to see the warnings on every build.
etungsten
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The singular
AddSettingMigrationandRemoveSettingMigrationexist forbackward compatibility and are marked deprecated. The trait implementations on
those items have to reference the deprecated items, of course, but this
triggers compiler warnings about use of the deprecated items. We only want
warnings when people are actively using these types outside of the module that
defines them; we don't want to see the warnings on every build.
Testing done:
Build no longer shows the warnings.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.