Skip to content

Commit

Permalink
Merge pull request #3001 from stmcginnis/ip6tables-cp
Browse files Browse the repository at this point in the history
[1.13.x] iptables: fix check for rule existence in ip6tables v1.8.9
  • Loading branch information
stmcginnis authored Apr 11, 2023
2 parents aaf6eeb + ed7e528 commit 0847e2f
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
From ba75342ff3e01605258810eb7f5683d8e326ffd8 Mon Sep 17 00:00:00 2001
From: Markus Boehme <[email protected]>
Date: Mon, 3 Apr 2023 22:20:23 +0200
Subject: [PATCH] ip6tables: Fix checking existence of rule

Pass the proper entry size when creating a match mask for checking the
existence of a rule. Failing to do so causes wrong results.

Reported-by: Jonathan Caicedo <[email protected]>
Fixes: eb2546a846776 ("xshared: Share make_delete_mask() between ip{,6}tables")
Signed-off-by: Markus Boehme <[email protected]>
---
iptables/ip6tables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/iptables/ip6tables.c b/iptables/ip6tables.c
index 345af451..9afc32c1 100644
--- a/iptables/ip6tables.c
+++ b/iptables/ip6tables.c
@@ -331,7 +331,7 @@ check_entry(const xt_chainlabel chain, struct ip6t_entry *fw,
int ret = 1;
unsigned char *mask;

- mask = make_delete_mask(matches, target, sizeof(fw));
+ mask = make_delete_mask(matches, target, sizeof(*fw));
for (i = 0; i < nsaddrs; i++) {
fw->ipv6.src = saddrs[i];
fw->ipv6.smsk = smasks[i];
--
2.25.1

1 change: 1 addition & 0 deletions packages/iptables/iptables.spec
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Requires: %{_cross_os}libnftnl
Requires: %{_cross_os}libnetfilter_conntrack

Patch1001: 1001-extensions-NAT-Fix-for-Werror-format-security.patch
Patch1002: 1002-ip6tables-Fix-checking-existence-of-rule.patch

%description
%{summary}.
Expand Down

0 comments on commit 0847e2f

Please sign in to comment.