Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX: controller: add retry logic to controller it's unable to find resources #816

Merged
merged 1 commit into from
May 9, 2023

Conversation

gthao313
Copy link
Member

@gthao313 gthao313 commented Apr 28, 2023

Issue number:
close: #817

Description of changes:
There is a race condition when running ecs-migration-test because the resource comes out late and is recognized as not found resources. Add retry logics on it to avoid mistakenly error out.

Testing done:

 NAME                                                                              TYPE                               STATE                                                      PASSED                          FAILED                          SKIPPED
 x86-64-aws-ecs-1-migration-test-cluster-test-1-initial                            Test                               passed                                                          1                               0                                0
 x86-64-aws-ecs-1-migration-test-cluster-test-2-migrate                            Test                               passed                                                          2                               0                                0
 x86-64-aws-ecs-1-migration-test-cluster-test-3-migrated                           Test                               passed                                                          1                               0                                0
 x86-64-aws-ecs-1-migration-test-cluster-test-4-migrate                            Test                               passed                                                          2                               0                                0
 x86-64-aws-ecs-1-migration-test-cluster-test-5-final                              Test                               passed                                                          1                               0                                0
 x86-64-aws-ecs-1-migration-test-cluster                                           Resource                           completed
 x86-64-aws-ecs-1-migration-test-cluster-instances                                 Resource                           completed

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@gthao313 gthao313 requested review from webern and ecpullen May 3, 2023 17:24
@gthao313 gthao313 marked this pull request as ready for review May 3, 2023 17:24
controller/src/test_controller/action.rs Outdated Show resolved Hide resolved
@gthao313 gthao313 merged commit 6ff9a89 into bottlerocket-os:develop May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] race condition at controller action
3 participants