Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsys: shorten default namespace and CRD API group #633

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

etungsten
Copy link
Contributor

@etungsten etungsten commented Oct 31, 2022

Issue number:
Resolves #628

Description of changes:


    testsys: shorten default namespace to 'testsys'
    
    This shortens TestSys default namespace from 'testsys-bottlerocket-aws'
    to 'testsys'
    testsys: change CRD API group to 'testsys.system'
    
    This changes the TestSys CRD API group from 'testsys.bottlerocket.aws'
    to 'testsys.system'. This makes it less specific to Bottlerocket when
    TestSys can be used to test other OSes in any K8s cluster.

Testing done:
All testsys images built fine, testsys CLI installs fine.

Deployed testsys to K8s cluster, testsys api-resources are created in the testsys namespace as expected.
TestSys CRD group/APIVersion is as expected:

$ kubectl api-resources 
...
resources                                      testsys.system/v1                      true         Resource
tests                                          testsys.system/v1                      true         Test


$ kubectl get pods -A
NAMESPACE     NAME                                  READY   STATUS    RESTARTS   AGE
...
testsys       testsys-controller-5595cc7b94-g8npd   1/1     Running   0          60s


$ kubectl get crds
NAME                                         CREATED AT
eniconfigs.crd.k8s.amazonaws.com             2022-08-10T21:55:07Z
resources.testsys.system                     2022-10-31T19:38:35Z
securitygrouppolicies.vpcresources.k8s.aws   2022-08-10T21:55:10Z
tests.testsys.system                         2022-10-31T19:38:35Z

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use a legitimate domain name like testsys.com.

This changes the TestSys CRD API group from 'testsys.bottlerocket.aws'
to 'testsys.system'. This makes it less specific to Bottlerocket when
TestSys can be used to test other OSes in any K8s cluster.
This shortens TestSys default namespace from 'testsys-bottlerocket-aws'
to 'testsys'
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@etungsten etungsten requested a review from ecpullen October 31, 2022 19:39
@etungsten etungsten merged commit 05be9b7 into bottlerocket-os:develop Oct 31, 2022
@etungsten etungsten deleted the shorten-name branch October 31, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename testsys namespace and apiversion to something other than testsys.bottlerocket.aws
4 participants