Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nvidia shared GPU settings to k8s model #49

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

monirul
Copy link
Contributor

@monirul monirul commented Aug 7, 2024

Issue #, if available:

Description of changes:
This PR introduces two new fields within the NvidiaDevicePluginSettings structure: max_sharing_per_gpu and rename_shared_gpu. These new fields are for managing the timeslicing capabilities of Nvidia GPUs.

Setting max_sharing_per_gpu to 1 deactivates time-slicing, effectively disabling GPU sharing. Conversely, a value greater than 1 activates time-slicing, resulting in the creation of the specified number of GPU replicas.

The rename_shared_gpu field dictates the naming convention for shared GPU resources. A false value retains the original GPU name, while true triggers a renaming process, appending .shared to the GPU identifier. For instance, enabling this feature would transform nvidia.com/gpu to nvidia.com/gpu.shared.

By contributing this pull request, I grant permission to use, modify, replicate, and distribute my submission, in accordance with your preferred terms.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice."

@monirul monirul force-pushed the timeslicing-changes branch 2 times, most recently from c4db904 to 835cb24 Compare August 9, 2024 20:17
@monirul monirul requested review from bcressey and cbgbt August 9, 2024 20:17
@cbgbt
Copy link
Contributor

cbgbt commented Aug 9, 2024

The code looks good to me! Do you mind rewriting the git commit message? I'll implement a linter for this, but the settings SDK tends to follow the conventional commit style.

You could rewrite the message as:

feat: add nvidia shared GPU settings to k8s model

@monirul monirul force-pushed the timeslicing-changes branch 2 times, most recently from 46c41bf to 0478ba2 Compare August 9, 2024 23:48
@monirul monirul changed the title Nvidia GPU Time-slicing settings changes feat: add nvidia shared GPU settings to k8s model Aug 9, 2024
@monirul monirul force-pushed the timeslicing-changes branch 2 times, most recently from 25fe5a2 to 603cc2d Compare August 12, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants