-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings extension for Nvidia settings APIs #43
Conversation
Looks like you may need to run |
9a174d9
to
bf4bf8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub actions CI workflow runs make build
-- you could use the same target locally to iterate on getting it to pass.
bottlerocket-settings-models/settings-models/src/kubernetes/mod.rs
Outdated
Show resolved
Hide resolved
bottlerocket-settings-models/settings-models/src/kubernetes/mod.rs
Outdated
Show resolved
Hide resolved
8b5de17
to
4df0197
Compare
I'm overall pretty happy with this, other than some minor suggestions (and of course, getting the build to pass 😄) |
a8f37fd
to
efc4613
Compare
#[serde(rename_all = "kebab-case")] | ||
pub enum NvidiaDeviceListStrategy { | ||
Envvar, | ||
VolumeMounts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does device-list-strategy = "volume-mounts"
here imply that visible-devices-as-volume-mounts
should also be true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
bottlerocket-settings-models: prepare for v0.2.0 release
efc4613
to
566e996
Compare
Looks good to me. |
Issue #, if available:
Description of changes:
This PR contains the settings sdk changes for Nvidia api. In this PR, we have add the settings for
settings.nvidia-container-runtime
andsettings.kubernetes.device-plugin.nvidia
.Testing done:
Yes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.