Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new type for the kubernetes hostname override mode #42

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Jul 16, 2024

Issue #, if available:

N/A

Description of changes:

Adds a new type to be used when configuring the hostname override mode.

[root@admin]# apiclient set settings.kubernetes.hostname-override-source=asd
Failed to change settings: Failed PATCH request to '/settings/keypair?tx=apiclient-set-0PV6YalhON4ZW9bb': Status 400 when PATCHing /settings/keypair?tx=apiclient-set-0PV6YalhON4ZW9bb: Unable to match your input to the data model.  We may not have enough type information.  Please try the --json input form.  Cause: Error during deserialization: unknown variant `asd`, expected `private-dns-name` or `instance-id` at line 1 column 47

[root@admin]# apiclient set settings.kubernetes.hostname-override-source=private-dns-name

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tzneal tzneal force-pushed the add-hostname-override-type branch 5 times, most recently from 05dee7b to 78c8db2 Compare July 16, 2024 19:44
@tzneal tzneal marked this pull request as draft July 16, 2024 21:07
@tzneal tzneal force-pushed the add-hostname-override-type branch from 78c8db2 to 677e113 Compare July 16, 2024 21:19
@tzneal tzneal force-pushed the add-hostname-override-type branch from 677e113 to dc65912 Compare July 16, 2024 21:23
@tzneal tzneal marked this pull request as ready for review July 17, 2024 01:39
@arnaldo2792 arnaldo2792 requested a review from cbgbt July 17, 2024 01:54
@cbgbt cbgbt merged commit 1687036 into bottlerocket-os:develop Jul 25, 2024
1 check passed
@tzneal tzneal deleted the add-hostname-override-type branch July 25, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants