Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clippy to tools in rust configs #89

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

mjsterckx
Copy link
Contributor

@mjsterckx mjsterckx commented Feb 9, 2023

Issue number:

bottlerocket-os/bottlerocket#2704

Description of changes:

Added clippy to the tools vec in the Rust configs so linting can be done via the SDK instead of local cargo installs.

Testing done:

Built x86_64 and aarch64 SDK and toolchain on x86_64 host and aarch64 host

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mjsterckx mjsterckx marked this pull request as ready for review February 10, 2023 05:02
@webern webern merged commit dcce686 into bottlerocket-os:develop Feb 10, 2023
@mjsterckx mjsterckx deleted the add-clippy branch February 14, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants