Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go version to 1.14.1 #21

Merged
merged 2 commits into from
Mar 23, 2020
Merged

Upgrade go version to 1.14.1 #21

merged 2 commits into from
Mar 23, 2020

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Mar 21, 2020

Issue number:
Fixes #20

Description of changes:
Upgrade go version to 1.14.1

Testing done:
Manually change Dockerfile as per below to test

COPY ./go1.14.1.src.tar.gz ./go1.14.1.src.tar.gz
#RUN \
#  sdk-fetch hashes && \
#  tar xf go${GOVER}.src.tar.gz && \
#  rm go${GOVER}.src.tar.gz

RUN tar xf go${GOVER}.src.tar.gz

Check go verison

$ docker run -it bottlerocket/sdk-x86_64:v0.10.1 /bin/sh
sh-5.0$ go version
go version go1.14.1 linux/amd64
sh-5.0$ rustc --version
rustc 1.42.0

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

The change looks good to me. It'd be great if someone could build an image and confirm our Go components still work; I'm not set up to do that at the moment.

@sayboras sayboras changed the title Bump go version to 1.14.1 Upgrade go version to 1.14.1 Mar 23, 2020
@iliana iliana self-assigned this Mar 23, 2020
@bcressey bcressey removed their request for review March 23, 2020 16:25
@iliana
Copy link
Contributor

iliana commented Mar 23, 2020

Testing looks good, I'll go ahead and get this released and published. Thanks!

@iliana iliana merged commit c46fff6 into bottlerocket-os:develop Mar 23, 2020
@iliana
Copy link
Contributor

iliana commented Mar 23, 2020

Bottlerocket PR: bottlerocket-os/bottlerocket#866

@sayboras
Copy link
Contributor Author

Bottlerocket PR: bottlerocket-os/bottlerocket#866

Thanks a lot 💯

@sayboras sayboras deleted the bugfix/go-mlock branch March 23, 2020 22:51
KCSesh pushed a commit to KCSesh/bottlerocket-sdk that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang 1.14 mlock issue
3 participants