Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license header to enable-admin-container #2

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

iliana
Copy link
Contributor

@iliana iliana commented Feb 26, 2020

Issue number:

bottlerocket-os/bottlerocket#469

Description of changes:

We normally don't add license headers to files in Bottlerocket, but enable-admin-container is the only file in the control container written by us (in this case, the Bottlerocket developers) that warrants license information. In this case, we believe a copyright header is the right thing instead of adding COPYRIGHT and LICENSE-*.

Testing done:

make works. The shell script runs fine.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

We normally don't add license headers to files in Bottlerocket, but
enable-admin-container is the only file in the control container written
by us that warrants license information. In this case, we believe a
copyright header is the right thing instead of adding COPYRIGHT and
LICENSE-*.
Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(technical approval)

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iliana iliana merged commit 0eeb7f8 into develop Feb 26, 2020
@jpculp jpculp deleted the license-header branch June 16, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants