Switch paths from host-containers/admin to host-containers/current
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces any code that referenced `host-containers/admin` with the recently introduced `current` dir to support admin containers with a custom name.
webern
approved these changes
Mar 31, 2021
etungsten
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
This replaces any code that referenced
host-containers/adminwith the recently introducedcurrentdir to support admin containers with a custom name.Testing done:
aws-ecs-1ami with theadmincontainer disabled and acustom-admincontainer enabled.custom-admincontainer via ssh./.bottlerocket/host-containerscontained two directories:custom-adminandcurrentcat etc/ssh/sshd_configto verify the host keys mapped to/.bottlerocket/host-containers/current/etc/ssh/./.bottlerocket/host-containers/current/etc/ssh/contained host keys.sudo sheltieto verify root shell was still available.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.